-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSN for conda package legacy
labelling
#570
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
def31c7
to
e20ea8c
Compare
_notices/rsn0042.md
Outdated
|
||
RAPIDS will move certain older conda packages in the `rapidsai` conda channel | ||
under a new label: `legacy`. These packages will still be available by appending | ||
`--label legacy` to installation and search commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little unclear on this. It looks like --label
is used when uploading, but for users to install, they need something like --channel rapidsai --channel rapidsai/label/legacy
. Does that sound correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, thanks for catching that @bdice !
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One small suggestion and one question.
All RAPIDS conda install commands for RAPIDS versions `v23.04+` will continue to | ||
work without any user intervention. | ||
|
||
This change will occur concurrently with the release of RAPIDS `v25.04`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking: We will be able to test strict channel priority in our CI before the 25.04 release, right? I want to be sure we minimize the risk of breaking recent releases (25.02 / 25.04) during this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll be able to test 25.02
once all of those packages are released using the same method I tested the previous releases with. Regarding 25.04, we can also release all of those packages, test, then move the selected older packages under the legacy
label, or we can move them under the label
, see if it works, and then undo the labeling if it breaks.
If 25.02
works, I'd feel confident moving the packages straight to the label
for 25.04, and that would let us accurately advertise strict channel priority for the new install instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's helpful. What about enabling strict priority in our CI for PR & nightly builds/tests, though? It sounds like you're discussing the user experience that we expect after the release is complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't really enable them for CI until we move the older packages under legacy
. The conda-metachannel
package is quite brittle at this point and I don't think we want that spun up as part of our CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean we will make the legacy
label along with the 25.04 release, and then enable strict priority in our CI during development for 25.06?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
RSN for moving select conda packages behind a new
legacy
label concurrent with thev25.04
release.I wasn't sure whether to note the
notice_rapids_version
as the version wherethis change takes place (
25.04
) or the versions impacted by the change(
<=23.02
). I think<=23.02
makes more sense and I've written it as such, buthappy to change things around.
xref rapidsai/build-planning#84