Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSN for conda package legacy labelling #570

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gforsyth
Copy link

@gforsyth gforsyth commented Jan 27, 2025

RSN for moving select conda packages behind a new legacy label concurrent with the v25.04 release.

I wasn't sure whether to note the notice_rapids_version as the version where
this change takes place (25.04) or the versions impacted by the change
(<=23.02). I think <=23.02 makes more sense and I've written it as such, but
happy to change things around.

xref rapidsai/build-planning#84

@gforsyth gforsyth requested a review from a team as a code owner January 27, 2025 16:48
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 28, 2025 7:44pm

Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2417de8
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/6799337606a17e00085fedd4
😎 Deploy Preview https://deploy-preview-570--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


RAPIDS will move certain older conda packages in the `rapidsai` conda channel
under a new label: `legacy`. These packages will still be available by appending
`--label legacy` to installation and search commands.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little unclear on this. It looks like --label is used when uploading, but for users to install, they need something like --channel rapidsai --channel rapidsai/label/legacy. Does that sound correct?

See https://docs.anaconda.com/anacondaorg/user-guide/work-with-labels/#testing-the-discoverability-of-the-package

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks for catching that @bdice !

_notices/rsn0042.md Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small suggestion and one question.

_notices/rsn0042.md Outdated Show resolved Hide resolved
All RAPIDS conda install commands for RAPIDS versions `v23.04+` will continue to
work without any user intervention.

This change will occur concurrently with the release of RAPIDS `v25.04`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: We will be able to test strict channel priority in our CI before the 25.04 release, right? I want to be sure we minimize the risk of breaking recent releases (25.02 / 25.04) during this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be able to test 25.02 once all of those packages are released using the same method I tested the previous releases with. Regarding 25.04, we can also release all of those packages, test, then move the selected older packages under the legacy label, or we can move them under the label, see if it works, and then undo the labeling if it breaks.

If 25.02 works, I'd feel confident moving the packages straight to the label for 25.04, and that would let us accurately advertise strict channel priority for the new install instructions.

Copy link
Contributor

@bdice bdice Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's helpful. What about enabling strict priority in our CI for PR & nightly builds/tests, though? It sounds like you're discussing the user experience that we expect after the release is complete.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't really enable them for CI until we move the older packages under legacy. The conda-metachannel package is quite brittle at this point and I don't think we want that spun up as part of our CI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean we will make the legacy label along with the 25.04 release, and then enable strict priority in our CI during development for 25.06?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
_notices/rsn0042.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants