Forward-merge branch-24.02 to branch-24.04 #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes attempted in rapidsai/integration#695 & rapidsai/integration#697 don't play well with CEC at large, but this repo can pin `cuda-python` more restrictively. This PR pins `cuda-python` to the CUDA `major.minor.*` version. See also conda-forge/cuda-python-feedstock#66 Authors: - Ray Douglass (https://github.com/raydouglass) Approvers: - Bradley Dice (https://github.com/bdice) - Jake Awe (https://github.com/AyodeAwe) URL: rapidsai#624
Looks like all occurences of `DASK_SQL_VER` use the full version tag - should we modify [the logic in the version updating workflow](https://github.com/charlesbluca/docker/blob/12323a46f1a05f80d1e9354b3dbc0e3937227cc4/.github/workflows/update-dask-sql.yml#L49-L53) to reflect this? Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#623
Now that `cuda-python` packaging has been fixed to enable CUDA Enhanced Compatibility in conda-forge/cuda-python-feedstock#67, we can unpin `cuda-python` in our Docker builds. This reverts commit 7c808e7. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#628
raydouglass
approved these changes
Mar 4, 2024
|
/merge |
|
Oops this squashed merged 🤦♂️ Fixing with PR: #637 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #626
Fixes #630 (as this contains the Dask-SQL 2024.1.0 update already)