Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #620

Merged
merged 13 commits into from
Aug 14, 2024
Merged

Fix tests #620

merged 13 commits into from
Aug 14, 2024

Conversation

AjayThorve
Copy link
Member

@AjayThorve AjayThorve commented Aug 14, 2024 •
edited
Loading

This PR fixes

  1. failing tests, which were caused by duplicate columns in the core_graph source_df.

  2. Failing external tests

@AjayThorve AjayThorve requested a review from a team as a code owner August 14, 2024 00:13
@AjayThorve AjayThorve added non-breaking Non-breaking change bug Something isn't working labels Aug 14, 2024
@AjayThorve AjayThorve requested a review from a team as a code owner August 14, 2024 00:27
@AjayThorve AjayThorve requested a review from bdice August 14, 2024 00:27
@github-actions github-actions bot added the ci label Aug 14, 2024
@AjayThorve AjayThorve changed the title Fix duplicate column tests Fix tests Aug 14, 2024
@AjayThorve AjayThorve requested a review from a team as a code owner August 14, 2024 18:36
@jakirkham jakirkham requested a review from mroeschke August 14, 2024 19:45
mroeschke
mroeschke approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python change LGTM

@jakirkham jakirkham requested a review from exactlyallan August 14, 2024 19:55
bdice
bdice approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, with one suggested refactor.

python/cuxfilter/charts/core/non_aggregate/core_graph.py Show resolved Hide resolved
@AjayThorve
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit c325c7f into rapidsai:branch-24.10 Aug 14, 2024
27 checks passed
@AjayThorve AjayThorve deleted the fix-tests branch August 14, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@exactlyallan exactlyallan exactlyallan approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ci non-breaking Non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AjayThorve @bdice @exactlyallan @mroeschke