Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch 24.10 merge 24.08 #611

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

jameslamb
Copy link
Member

Replaces #610

Fixes forward-merger conflicts, per https://docs.rapids.ai/maintainers/forward-merger

Contributes to rapidsai/build-planning#31

In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. `cudf` depending on `rmm`, not `rmm-cu12`.

This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in `dependencies.yaml`.

For more details, see:
* rapidsai/build-planning#31 (comment)
* rapidsai/cudf#16183

## Notes for Reviewers

### Why target 24.08?

This is targeting 24.08 because:

1. it should be very low-risk
2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#609
@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 25, 2024
@jameslamb jameslamb requested review from a team as code owners July 25, 2024 14:04
@jameslamb jameslamb requested a review from KyleFromNVIDIA July 25, 2024 14:04
@jameslamb jameslamb removed the improvement Improvement / enhancement to an existing function label Jul 25, 2024
@jameslamb jameslamb changed the base branch from branch-24.08 to branch-24.10 July 25, 2024 14:07
@jameslamb
Copy link
Member Author

Tests here are failing because I guess there's hasn't yet been a successful publishing of cuspatial nightlies.

ERROR: No matching distribution found for cuspatial-cu12==24.10.*,>=0.0.0a0

(build link)

@AyodeAwe AyodeAwe merged commit effdb6c into rapidsai:branch-24.10 Jul 25, 2024
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci conda doc Documentation non-breaking Non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants