Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use public cudf APIs where possible #578

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Use public cudf APIs where possible #578

merged 2 commits into from
Mar 6, 2024

Conversation

mroeschke
Copy link
Contributor

cudf's core namespace is considered "private", so changing some usages that have public alternative.

@mroeschke mroeschke requested a review from a team as a code owner March 6, 2024 18:16
@github-actions github-actions bot added the Python label Mar 6, 2024
@AjayThorve AjayThorve added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 6, 2024
@AjayThorve
Copy link
Member

Might have to fix the style checks, but overall looks good, thanks for this!

AjayThorve
AjayThorve approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@AjayThorve AjayThorve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, pending style check fixes

@mroeschke
Copy link
Contributor Author

Thanks for the review! Style fixes should be addressed now

@AjayThorve
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 4b29fb8 into rapidsai:branch-24.04 Mar 6, 2024
30 checks passed
@mroeschke mroeschke deleted the imports/cudf/public branch March 6, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AjayThorve AjayThorve AjayThorve approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @AjayThorve