Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests failing due to unsorted results #479

Merged
merged 3 commits into from
May 31, 2023
Merged

fix tests failing due to unsorted results #479

merged 3 commits into from
May 31, 2023

Conversation

AjayThorve
Copy link
Member

@AjayThorve AjayThorve commented May 30, 2023 •
edited
Loading

This PR:

  • fixes a couple of tests which were failing due to recent changes, leading to aggregate results being unsorted
  • resolves docs build failures, which were caused by datashader rendering issues with latest numpy(1.24.3), fixed by adding a pin for numpy (<1.24, similar to the version pins in cugraph). @ajschmidt8, could you check if adding this version pin is fine?

@AjayThorve AjayThorve requested a review from a team as a code owner May 30, 2023 19:57
@AjayThorve AjayThorve added bug Something isn't working non-breaking Non-breaking change ci and removed ci labels May 30, 2023
@AjayThorve AjayThorve force-pushed the fix/failing-tests branch from 8c7bd14 to 3c69c2c Compare May 30, 2023 20:27
@AjayThorve AjayThorve requested a review from a team as a code owner May 30, 2023 21:32
@github-actions github-actions bot added the conda label May 30, 2023
@AjayThorve
Copy link
Member Author

/merge

@AjayThorve AjayThorve mentioned this pull request May 31, 2023
Merged
@jakirkham
Copy link
Member

Asked OPS for a review offline

@AjayThorve
Copy link
Member Author

AjayThorve commented May 31, 2023 •
edited
Loading

Numpy version 1.24.3 issue with datashader is fixed (holoviz/datashader#1176), but not yet released. Tracking it here, so that the version pin for numpy can be reverted once datashader releases 0.14.5.

@raydouglass
Copy link
Member

numpy can be reverted once datashader releases 0.14.5

Since #480 bumps datashader >=0.15, can the numpy upper bound pin be removed now?

@AjayThorve
Copy link
Member Author

@raydouglass I have removed the numpy requirements and updated the datashader version to >=0.15

@rapids-bot rapids-bot bot merged commit 472f839 into rapidsai:branch-23.06 May 31, 2023
@AjayThorve AjayThorve deleted the fix/failing-tests branch May 31, 2023 16:36
@raydouglass raydouglass mentioned this pull request Jun 13, 2023
Merged
raydouglass added a commit to rapidsai/integration that referenced this pull request Jun 13, 2023
@raydouglass
Update datashader pin (#658)
b0e52c6 
Updates the `datashader` to match rapidsai/cuxfilter#479

I confirmed this works locally.

Authors:
   - Ray Douglass (https://github.com/raydouglass)

Approvers:
   - Jake Awe (https://github.com/AyodeAwe)
   - AJ Schmidt (https://github.com/ajschmidt8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exactlyallan exactlyallan exactlyallan approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
bug Something isn't working conda non-breaking Non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AjayThorve @jakirkham @raydouglass @exactlyallan