-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies.yaml #416
Merged
ajschmidt8
merged 14 commits into
rapidsai:branch-23.02
from
AjayThorve:fea/dependencies
Dec 5, 2022
Merged
Add dependencies.yaml #416
ajschmidt8
merged 14 commits into
rapidsai:branch-23.02
from
AjayThorve:fea/dependencies
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajschmidt8
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Dec 5, 2022
bdice
requested changes
Dec 5, 2022
Comment on lines
+83
to
+85
- black=22.3.0 | ||
- flake8=3.8.3 | ||
- pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up: we should migrate CI to use pre-commit to manage linter versions and run style checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up PR created here: #420
bdice
reviewed
Dec 5, 2022
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
ajschmidt8
approved these changes
Dec 5, 2022
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
Updates style checks to use `pre-commit`. This was suggested in #416 and helps prepare the repository for the migration to GitHub Actions. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Ajay Thorve (https://github.com/AjayThorve) URL: #420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conda
gpuCI
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the dependencies.yaml file to support the new rapids-dependency-file-generator.
cc @ajschmidt8