Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CuPy 11 #383

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Allow CuPy 11 #383

merged 2 commits into from
Jul 29, 2022

Conversation

jakirkham
Copy link
Member

Allows cuxfilter to be installed with CuPy 11.

xref: rapidsai/integration#508

@jakirkham jakirkham requested a review from a team as a code owner July 28, 2022 18:08
@github-actions github-actions bot added the conda label Jul 28, 2022
@jakirkham
Copy link
Member Author

Could someone please help add the appropriate labels here?

@AjayThorve AjayThorve added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 28, 2022
@jakirkham
Copy link
Member Author

Thank you both! 🙏

@AjayThorve
Copy link
Member

rerun tests

@jakirkham
Copy link
Member Author

Filed issue ( #384 ) to summarize what we are seeing on CI.

@jakirkham jakirkham mentioned this pull request Jul 29, 2022
Merged
AjayThorve
AjayThorve approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@AjayThorve AjayThorve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, cupy 11 doesn't cause any issues with cuxfilter. Thanks!

@AjayThorve
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 15e2895 into rapidsai:branch-22.08 Jul 29, 2022
@jakirkham jakirkham deleted the allow_cupy_11 branch July 29, 2022 16:08
galipremsagar added a commit to galipremsagar/cuxfilter that referenced this pull request Aug 1, 2022
@galipremsagar
Revert "Allow CuPy 11 (rapidsai#383)"
b8d5341 
This reverts commit 15e2895.
@galipremsagar galipremsagar mentioned this pull request Aug 1, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request Aug 1, 2022
@galipremsagar
Revert "Allow CuPy 11" (#388)
533c21b 
Reverts #383

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevagh sevagh sevagh approved these changes

@AjayThorve AjayThorve AjayThorve approved these changes

Assignees
No one assigned
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakirkham @AjayThorve @sevagh @ajschmidt8