Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conda to build python packages during GPU tests #368

Merged
merged 1 commit into from
May 10, 2022
Merged

Use conda to build python packages during GPU tests #368

merged 1 commit into from
May 10, 2022

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Apr 21, 2022 •
edited
Loading

This PR convert the from sources build we are doing in GPU test job to a conda build. This is done for the following reasons:

  • This is required step to improve the Ops CI/CD setup to a more convenient pipeline
  • This is required to start using conda compilers and mamba to build RAPIDS packages
  • This prevent us from manually managing and installing the dependencies in GPU job
  • This ensure the packages can be installed
  • This ensure the tests are running and working against the package content and not the build results. Currently the Python packages are not tested.

This may increase the global pipeline time, but the usage of mamba should resolve this as mamba is faster than conda to build packages

@jjacobelli jjacobelli added DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 21, 2022
@jjacobelli jjacobelli self-assigned this Apr 21, 2022
@jjacobelli jjacobelli requested review from a team as code owners April 21, 2022 13:13
@jjacobelli jjacobelli force-pushed the remove-from-sources branch from 36e342e to a7dd8b8 Compare April 21, 2022 13:39
@jjacobelli jjacobelli marked this pull request as draft April 21, 2022 17:08
@jjacobelli jjacobelli force-pushed the remove-from-sources branch from a7dd8b8 to c47c42a Compare April 25, 2022 09:35
@jjacobelli jjacobelli removed the DO NOT MERGE Hold off on merging; see PR for details label Apr 25, 2022
@jjacobelli jjacobelli marked this pull request as ready for review April 25, 2022 09:39
@jjacobelli
Copy link
Contributor Author

rerun tests

1 similar comment
@jjacobelli
Copy link
Contributor Author

rerun tests

@jjacobelli jjacobelli force-pushed the remove-from-sources branch from c47c42a to 3d31ab1 Compare May 4, 2022 19:45
AjayThorve
AjayThorve approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@AjayThorve AjayThorve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

ajschmidt8
ajschmidt8 requested changes May 9, 2022
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
@jjacobelli
Use conda to build python packages during GPU tests
2d439ca 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli force-pushed the remove-from-sources branch from 3d31ab1 to 2d439ca Compare May 10, 2022 11:12
@jjacobelli
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 68eb603 into rapidsai:branch-22.06 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@AjayThorve AjayThorve AjayThorve approved these changes

Assignees

@jjacobelli jjacobelli

Labels
gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjacobelli @ajschmidt8 @AjayThorve