Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reinit function #345

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

AjayThorve
Copy link
Member

Quick fix PR to fix the _reinit_all_charts function, which was no longer working due to the recent refactors

@AjayThorve AjayThorve requested a review from a team as a code owner January 20, 2022 21:53
@AjayThorve AjayThorve requested a review from bryevdv January 20, 2022 21:54
@AjayThorve AjayThorve added bug Something isn't working non-breaking Non-breaking change labels Jan 20, 2022
@bryevdv
Copy link
Contributor

bryevdv commented Jan 20, 2022

@AjayThorve is there a good test case or example to run to see before/after? Changes look OK at a glance but I don't really have any context for what exactly was broken

@AjayThorve
Copy link
Member Author

AjayThorve commented Jan 20, 2022

@bryevdv (pushed one more change after you reviewed). basically don't need to reinitialize data_size_indicator, separately, as that was fixed in a previous PR.

Current implementation was reinitializing it twice (line 320, 325), and this was leading to some inconsistencies in data size values if we ran d.app() twice, or d.show() twice in a row.

Ideally, it should just reinitialize all charts if we rerun the function, which now happens properly

@AjayThorve
Copy link
Member Author

@gpucibot merge

@AjayThorve
Copy link
Member Author

rerun tests

1 similar comment
@AjayThorve
Copy link
Member Author

rerun tests

@rapids-bot rapids-bot bot merged commit 4c9e69d into rapidsai:branch-22.02 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants