Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] API change for Panel Widget #256

Closed
exactlyallan opened this issue Mar 4, 2021 · 3 comments · Fixed by #262
Closed

[FEA] API change for Panel Widget #256

exactlyallan opened this issue Mar 4, 2021 · 3 comments · Fixed by #262
Assignees
@AjayThorve
Labels
feature request New feature or request

Comments

@exactlyallan
Copy link
Member

Issue:
Currently panel widgets are considered 'charts' e.g. charts.range_slider, but are not considered part of the layout chart order. This can be confusing in creating custom layouts.

Proposal:
Move 'Panel Widgets' outside of charts, up one level e.g.:
cuxfilter.charts.multi_select('year') -> cuxfilter.panel_widget.multi_select('year')
@exactlyallan exactlyallan added the feature request New feature or request label Mar 4, 2021
@github-actions
Copy link

github-actions bot commented Apr 4, 2021

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@AjayThorve
Copy link
Member

@exactlyallan one solution to this problem is we add a sidebar argument to this dashboard function:

d = cux_df.dashboard(charts=charts_list, sidebar=[widget_chart1, widget_chart2], layout_array=[
    [1, 1, 2, 2],
    [1, 1, 3, 4]
], theme=cuxfilter.themes.rapids, title="Layout - Custom")

that way, only list of charts are considered while computing the layout array

@exactlyallan
Copy link
Member Author

For consistency and added functionality, lets make the panel widgets able to be used in the chart layout area as well.

@AjayThorve AjayThorve mentioned this issue Apr 6, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #262 Apr 7, 2021
rapids-bot bot pushed a commit that referenced this issue Apr 7, 2021
@AjayThorve
Fea/sidebar api change (#262)
d499b17 
This PR
1. Implements a sidebar api for dashboard function, closes #256 :

```python
d = cux_df.dashboard(charts=charts_list, sidebar=[widget_chart1, widget_chart2], layout_array=[
    [1, 1, 2, 2],
    [1, 1, 3, 4]
], theme=cuxfilter.themes.rapids, title="Layout - Custom")
```
2. fixes #259
3. minor refactors wherever possible to use f-strings 
4. updates docs to reflect `sidebar` prop usage

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - Bryan Van de Ven (https://github.com/bryevdv)

URL: #262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AjayThorve AjayThorve

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fea/sidebar api change AjayThorve/cuxfilter
2 participants
@exactlyallan @AjayThorve