Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug build failure #4774

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Fix debug build failure #4774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
04aa50f
fix build error
seunghwak Nov 19, 2024
350e2e7
fix warnings
seunghwak Nov 19, 2024
9cce314
clang-format
seunghwak Nov 20, 2024
de75ea6
Merge branch 'branch-24.12' into bug_build
seunghwak Nov 21, 2024
3753e1b
Merge branch 'branch-24.12' into bug_build
ChuckHastings Nov 22, 2024
f2091d5
Merge branch 'branch-24.12' into bug_build
seunghwak Nov 22, 2024
d8f5291
Merge branch 'branch-24.12' into bug_build
seunghwak Nov 22, 2024
d87566c
Merge branch 'branch-24.12' into bug_build
seunghwak Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions cpp/src/prims/detail/sample_and_compute_local_nbr_indices.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,8 +597,6 @@ rmm::device_uvector<edge_t> compute_uniform_sampling_index_without_replacement(
raft::random::RngState& rng_state,
size_t K)
{
assert(cugraph::invalid_edge_id_v<edge_t> == cugraph::ops::graph::INVALID_ID<edge_t>);

edge_t mid_partition_degree_range_last = static_cast<edge_t>(K * 10); // tuning parameter
assert(mid_partition_degree_range_last > K);
size_t high_partition_oversampling_K = K * 2; // tuning parameter
Expand Down Expand Up @@ -1567,10 +1565,7 @@ uniform_sample_and_compute_local_nbr_indices(
size_t K,
bool with_replacement)
{
using edge_t = typename GraphViewType::edge_type;

assert(cugraph::invalid_edge_id_v<edge_t> == cugraph::ops::graph::INVALID_ID<edge_t>);

using edge_t = typename GraphViewType::edge_type;
using vertex_t = typename GraphViewType::vertex_type;
using key_t = typename thrust::iterator_traits<KeyIterator>::value_type;

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/sampling/neighbor_sampling_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ neighbor_sample_impl(raft::handle_t const& handle,
? (fan_out.size() / num_edge_types)
: ((fan_out.size() / num_edge_types) + 1);

for (auto hop = 0; hop < num_hops; hop++) {
for (size_t hop = 0; hop < num_hops; ++hop) {
for (auto edge_type_id = 0; edge_type_id < num_edge_types; edge_type_id++) {
auto k_level = fan_out[(hop * num_edge_types) + edge_type_id];
rmm::device_uvector<vertex_t> srcs(0, handle.get_stream());
Expand Down
Loading