Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] fix_tests #1008

Merged
merged 2 commits into from
Jul 20, 2020
Merged

[REVIEW] fix_tests #1008

merged 2 commits into from
Jul 20, 2020

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Jul 17, 2020 •
edited
Loading

Update tests in correspondence to cudf PR rapidsai/cudf#5340

@Iroy30 Iroy30 requested a review from a team as a code owner July 17, 2020 01:34
ChuckHastings
ChuckHastings approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

I think the Renumber notebook also needs this update.

@xcadet xcadet mentioned this pull request Jul 17, 2020
Merged
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020 •
edited
Loading

Codecov Report

Merging #1008 into branch-0.15 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.15    #1008   +/-   ##
============================================
  Coverage        62.80%   62.80%           
============================================
  Files               57       57           
  Lines             1624     1624           
============================================
  Hits              1020     1020           
  Misses             604      604

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c66273...37f65ea. Read the comment docs.

@Iroy30 Iroy30 mentioned this pull request Jul 17, 2020
Merged
@ChuckHastings ChuckHastings mentioned this pull request Jul 17, 2020
Merged
@afender afender merged commit 84cb018 into rapidsai:branch-0.15 Jul 20, 2020
@BradReesWork BradReesWork added this to the 0.15 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschaffer aschaffer aschaffer approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@afender afender afender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
6 participants
@Iroy30 @codecov-commenter @aschaffer @ChuckHastings @afender @BradReesWork