Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get_arrow to arrows 12 CMake target name of arrow::xsimd #13790

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Update get_arrow to arrows 12 CMake target name of arrow::xsimd #13790

merged 1 commit into from
Aug 1, 2023

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Jul 31, 2023 •
edited
Loading

Description

Arrow 12.0 uses the vendored CMake target arrow::xsimd instead of the global target name of xsimd. We need to use the new name so that libcudf can be used from the build directory by other projects.

Found by issue: NVIDIA/spark-rapids-jni#1306

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jul 31, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner July 31, 2023 21:06
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jul 31, 2023
@gerashegalov gerashegalov mentioned this pull request Jul 31, 2023
Closed
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c7b5d22 into rapidsai:branch-23.10 Aug 1, 2023
@robertmaynard robertmaynard deleted the bug/update_cmake_arrow_target_names branch August 1, 2023 14:31
@robertmaynard robertmaynard mentioned this pull request Aug 1, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Aug 2, 2023
@robertmaynard
Bug/update libcudf to handle arrow12 changes (#13794)
d526530 
Contiuation of #13790 as more changes are needed to support Arrow 12 builds from source ( both static and shared ). This fixes issues when building against Arrow with S3 enabled, and corrects missing `acero` targets.

NVIDIA/spark-rapids-jni#1306

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Gera Shegalov (https://github.com/gerashegalov)
  - Bradley Dice (https://github.com/bdice)

URL: #13794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @bdice