-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor group_nunique.cu to use nullate::DYNAMIC for reduce-by-key functor #11482
Refactor group_nunique.cu to use nullate::DYNAMIC for reduce-by-key functor #11482
Conversation
The benchmark from #11472 was used to check the change in performance.
All diffs are less than 2% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to say, I love nullate::DYNAMIC
. Such a nice solution.
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #11482 +/- ##
===============================================
Coverage ? 86.47%
===============================================
Files ? 144
Lines ? 22856
Branches ? 0
===============================================
Hits ? 19765
Misses ? 3091
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@gpucibot merge |
Description
Refactored the
group_nunique.cu
source to use thenullate::DYNAMIC
for the equal operator and the unique-iterator. This improves the compile time by almost 2x without much change to performance by reducing the number of calls tothrust::reduce_by_key
.Found while investigating compile issues for #11437
Checklist