Skip to content

Commit

Permalink
Remove squeeze argument from groupby (#16312)
Browse files Browse the repository at this point in the history
In pandas, this argument was deprecated in pandas 1.x and removed in pandas 2.x. xref pandas-dev/pandas#33218

Looks like in cudf this argument was never implemented, so to align with pandas, I think it should be OK to just remove this argument

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #16312
  • Loading branch information
mroeschke authored Jul 19, 2024
1 parent cb570fe commit 3df4ac2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
2 changes: 0 additions & 2 deletions python/cudf/cudf/core/dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -4306,7 +4306,6 @@ def groupby(
as_index=True,
sort=no_default,
group_keys=False,
squeeze=False,
observed=True,
dropna=True,
):
Expand All @@ -4317,7 +4316,6 @@ def groupby(
as_index,
sort,
group_keys,
squeeze,
observed,
dropna,
)
Expand Down
6 changes: 0 additions & 6 deletions python/cudf/cudf/core/indexed_frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -5249,7 +5249,6 @@ def groupby(
as_index=True,
sort=no_default,
group_keys=False,
squeeze=False,
observed=True,
dropna=True,
):
Expand All @@ -5259,11 +5258,6 @@ def groupby(
if axis not in (0, "index"):
raise NotImplementedError("axis parameter is not yet implemented")

if squeeze is not False:
raise NotImplementedError(
"squeeze parameter is not yet implemented"
)

if not observed:
raise NotImplementedError(
"observed parameter is not yet implemented"
Expand Down
2 changes: 0 additions & 2 deletions python/cudf/cudf/core/series.py
Original file line number Diff line number Diff line change
Expand Up @@ -3368,7 +3368,6 @@ def groupby(
as_index=True,
sort=no_default,
group_keys=False,
squeeze=False,
observed=True,
dropna=True,
):
Expand All @@ -3379,7 +3378,6 @@ def groupby(
as_index,
sort,
group_keys,
squeeze,
observed,
dropna,
)
Expand Down

0 comments on commit 3df4ac2

Please sign in to comment.