Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packaging lib to ci-conda image #189

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add packaging lib to ci-conda image #189

merged 2 commits into from
Sep 24, 2024

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Sep 24, 2024 •
edited
Loading

Installs the packaging lib, which is used in rapids-pip-wheel-version gha tool.

Related:

@AyodeAwe AyodeAwe marked this pull request as ready for review September 24, 2024 18:18
@AyodeAwe AyodeAwe requested a review from a team as a code owner September 24, 2024 18:18
@AyodeAwe AyodeAwe requested review from raydouglass and removed request for a team September 24, 2024 18:18
@jameslamb jameslamb self-requested a review September 24, 2024 18:21
jameslamb
jameslamb requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use conda to install this, and avoid adding another layer to the image.

ci-conda.Dockerfile Outdated Show resolved Hide resolved
@AyodeAwe AyodeAwe merged commit b1cff14 into rapidsai:main Sep 24, 2024
577 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyodeAwe @jameslamb