Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the miniforge-cuda repo into ci-imgs #48

Closed
6 tasks done
vyasr opened this issue Apr 22, 2024 · 5 comments
Closed
6 tasks done

Merge the miniforge-cuda repo into ci-imgs #48

vyasr opened this issue Apr 22, 2024 · 5 comments
Assignees

Comments

@vyasr
Copy link
Contributor

vyasr commented Apr 22, 2024

Currently we build a base image with CUDA and conda installed in the miniforge-cuda repo, then use that as a base for the conda images in the ci-imgs repo. Due to the tight coupling between these images, we trigger a rebuild of the ci-imgs whenever a PR is merged to miniforge-cuda. Given this tight coupling, I think we should consider merging these repos. Combining the repositories will make it easier to teach new build engineers about the pieces we have, and make it easier to maintain since it will reduce the amount of distinct processes required if there are changes that need to be coordinated between the repositories.

Tasks

Preview Give feedback
@jameslamb
Copy link
Member

I've added a task list here.

@bdice
Copy link
Contributor

bdice commented Aug 27, 2024

Here is the search I did for URLs to replace. https://github.com/search?q=org%3Arapidsai+github.com%2Frapidsai%2Fminiforge-cuda&type=code

I don't think there are any besides #97.

bdice added a commit that referenced this issue Aug 27, 2024
@bdice
Copy link
Contributor

bdice commented Aug 27, 2024

I requested archival of rapidsai/miniforge-cuda because all other tasks are complete.

@bdice
Copy link
Contributor

bdice commented Aug 27, 2024

Archival is complete. Closing this.

@bdice bdice closed this as completed Aug 27, 2024
@jameslamb
Copy link
Member

Thanks so much for finishing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants