Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Make sure you can't do a mutation twice simultaneously #740

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Feb 20, 2025

If you have a broken mouse that double clicks (or you just click twice very fast for some reason) you can bypass the standard disabled state and mutate twice. Magento generally does not like this---in most cases it will just mean one of the queries is eaten, but sometimes this can break things (e.g. create 2 exact same orders from 1 cart).

Copy link
Member

@royduin royduin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me, let's wait for @indykoning his review.

Copy link
Member

@indykoning indykoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@royduin royduin merged commit e585838 into master Feb 21, 2025
12 checks passed
@royduin royduin deleted the bugfix/query-simultaneously branch February 21, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants