[2.x] Only apply default value when config option is not found #736
+50
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royduin
previously approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Looking good to me, let's wait for @indykoning his review. Maybe a nice follow-up on this: RAP-1193
indykoning
reviewed
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving a config option you may end up getting a value of
NULL. The current implementation uses null-coalescing after getting the value, which causes thatNULLto be replaced by the default value. However, if the config key does actually exist then this is not the correct behavior.For example, if you don't want a
.htmlsuffix on your product pages, you set the config value toNULL. This then gets converted back into.htmlwhen indexing products, causing the wrong urls to be indexed.This PR fixes that by implementing a
defaultoption into thegetValuefunction and using that instead of the null-coalescing operator.