[3.x] GraphQL checkout #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master in graphql-checkout
|
Merged, feedback is still appreciated. Maybe @Jade-GG or @BobWez98? Internal reference RAP-980 was created to process possible feedback on this. But with this we can proceed with other things depending on this. While reviewing; think about upgrading and keep an eye on the upgrade guide: https://docs.rapidez.io/3.x/upgrading.html |
royduin
commented
Oct 23, 2024
royduin
commented
Oct 23, 2024
royduin
commented
Oct 23, 2024
royduin
commented
Oct 23, 2024
royduin
commented
Oct 23, 2024
|
Don't forget the older unresolved conversations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
customer?.idwill no longer be available.This can be replaced with Rapidez' loggedIn property.
If backwards compatibility is not a factor,
user.is_logged_incan be usedany
config.queries.cartor@include('rapidez::cart.queries.cart')need to be moved as the graphql file has been changed to a fragment.The newly added auth guard for the cart can be used to ensure someone has an active cart:
middleware('auth:magento-cart')Both token and mask have been moved into cookies, it is now possible to use
middleware('auth:magento-cart')andmiddleware('auth:magento-customer')on web routes.Removed hasOnlyVirtualItems from cart, use cart.is_virtual instead.
Removed VirtualItems from cart, as this was only used to determine hasOnlyVirtualItems.
InteractWithUser has been removed, use the
stores/useUserinsteadSupport dropped for Laravel 10
Support dropped for Magento <2.4.7