-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a named slot to separate attribute merges #24
Conversation
👍 |
Do we want this refactored on all the input components (where it makes sense)? There's quite a bit of |
Yeah, that would be nice! |
</div> | ||
@endisset | ||
<div class="flex w-full flex-wrap items-center justify-between gap-x-3"> | ||
{!! $wrapper->toHtml() ?: $slot !!} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you use after psuedo elements when you just can create a new <div?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, that isn't my code @JimmyHoenderdaal 😇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you use after psuedo elements when you just can create a new <div?
this is because you would otherwise need group-peer-checked to toggle, we can't assume people are using that since it isn't in rapidez by default
So now we've this: laravel/framework#48039 🚀 maybe wait for the release of that and add it as minimal requirement in the |
Follow-up to #23
This update lets us do magics like this:
Of course, you can still do:
or even:
This seems like the nicest approach to me.