Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add P-192 to pcurves #4190

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Add P-192 to pcurves #4190

merged 2 commits into from
Jul 15, 2024

Conversation

randombit
Copy link
Owner

@randombit randombit commented Jul 9, 2024 •
edited
Loading

Vs the BigInt approach, over 2x faster with GCC and 3-3.5x (!) faster with Clang

@randombit randombit force-pushed the jack/pcurves-p192 branch from 9fd55b1 to 390a9f2 Compare July 9, 2024 11:43
@coveralls
Copy link

coveralls commented Jul 9, 2024 •
edited
Loading

Coverage Status

coverage: 91.716% (+0.006%) from 91.71%
when pulling 1648716 on jack/pcurves-p192
into 5d42faa on master.

@randombit randombit added this to the Botan 3.6.0 milestone Jul 9, 2024
@randombit randombit force-pushed the jack/pcurves-p192 branch from 390a9f2 to 5c8d942 Compare July 10, 2024 07:41
@randombit randombit mentioned this pull request Jul 10, 2024
Open
37 tasks
@randombit randombit force-pushed the jack/pcurves-p192 branch from 5c8d942 to 1648716 Compare July 14, 2024 21:00
randombit added 2 commits July 14, 2024 17:01
@randombit
Add P-192 to pcurves
7a70ca0
@randombit
Add Solinas reduction for P-192
1648716 
Only faster on 32-bit, it seems. On x86-32 provides a ~20% speedup
@randombit randombit merged commit 5fd660b into master Jul 15, 2024
39 checks passed
@randombit randombit deleted the jack/pcurves-p192 branch July 15, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Botan 3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@randombit @coveralls