Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject overly long RSA ciphertexts #3344

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Conversation

randombit
Copy link
Owner

Previously we would ignore leading zero bytes, even if they made the overall text larger than the modulus.

Previously we would ignore leading zero bytes, even if they made the
overall text larger than the modulus.
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (74bf5ec) 88.15% compared to head (ee97441) 88.14%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3344      +/-   ##
==========================================
- Coverage   88.15%   88.14%   -0.01%     
==========================================
  Files         615      615              
  Lines       69993    69993              
  Branches     6949     6948       -1     
==========================================
- Hits        61701    61695       -6     
- Misses       5392     5403      +11     
+ Partials     2900     2895       -5     
Impacted Files Coverage Δ
src/lib/pubkey/rsa/rsa.cpp 85.78% <50.00%> (-0.46%) ⬇️
src/lib/pbkdf/argon2/argon2pwhash.cpp 69.69% <0.00%> (-9.10%) ⬇️
src/lib/asn1/der_enc.cpp 77.63% <0.00%> (-1.32%) ⬇️
src/lib/utils/cpuid/cpuid_x86.cpp 54.05% <0.00%> (-0.62%) ⬇️
src/tests/test_bigint.cpp 90.83% <0.00%> (ø)
src/lib/tls/tls12/tls_record.cpp 92.21% <0.00%> (+0.40%) ⬆️
src/lib/pubkey/dl_group/dl_group.cpp 85.45% <0.00%> (+0.67%) ⬆️
src/lib/pk_pad/iso9796/iso9796.cpp 96.80% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randombit randombit merged commit 4bca07a into master Mar 4, 2023
@randombit randombit deleted the jack/rsa-reject-long-ctext branch March 4, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants