Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail fast CI workflow #442

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

tomleb
Copy link
Contributor

@tomleb tomleb commented Jul 9, 2024

Issue: rancher/rancher#45231

Technically not required for rancher/rancher#45231 but related.

With flaky tests or Docker rate limit, it's very annoying to have a job's failure cancel another job. Instead, let all jobs run to completion, this way we can restart only the failed one.

With flaky tests or Docker rate limit, it's very annoying to have a
job's failure cancel another job. Instead, let all jobs run to
completion, this way we can restart only the failed one.
@tomleb tomleb requested a review from a team as a code owner July 9, 2024 16:52
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@tomleb tomleb merged commit 18fbc9b into rancher:release/v0.5 Jul 10, 2024
2 checks passed
@tomleb tomleb deleted the fail-fast-ci branch July 10, 2024 12:44
tomleb added a commit to tomleb/rancher-webhook that referenced this pull request Jul 10, 2024
With flaky tests or Docker rate limit, it's very annoying to have a
job's failure cancel another job. Instead, let all jobs run to
completion, this way we can restart only the failed one.
tomleb added a commit to tomleb/rancher-webhook that referenced this pull request Jul 10, 2024
With flaky tests or Docker rate limit, it's very annoying to have a
job's failure cancel another job. Instead, let all jobs run to
completion, this way we can restart only the failed one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants