Replace github-action versions with SHAs #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomleb
previously approved these changes
Jul 4, 2024
There was a problem hiding this comment.
LGTM
It's best to add the version number at the end of the line as a comment so that renovate can pick it up as shown here: #431.
One issue is that renovate won't update the comment with the link in it, so that will become stale eventually.
If you have time to add the version number in a comment after all the uses (even those not in this PR) then great, otherwise we'll do it later.
.github/workflows/release.yaml
Outdated
| @@ -136,7 +136,8 @@ jobs: | |||
| secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials password | DOCKER_PASSWORD | |||
|
|
|||
| - name: Set up QEMU | |||
| uses: docker/setup-qemu-action@v3 | |||
| # https://github.com/docker/setup-qemu-action/commit/5927c834f5b4fdf503fca6f4c7eccda82949e1ee | |||
| uses: docker/setup-qemu-action@5927c834f5b4fdf503fca6f4c7eccda82949e1ee | |||
There was a problem hiding this comment.
Suggested change
| uses: docker/setup-qemu-action@5927c834f5b4fdf503fca6f4c7eccda82949e1ee | |
| uses: docker/setup-qemu-action@5927c834f5b4fdf503fca6f4c7eccda82949e1ee # v3.1.0 |
.github/workflows/release.yaml
Outdated
| @@ -167,7 +168,8 @@ jobs: | |||
| touch "/tmp/digests/${digest#sha256:}" | |||
|
|
|||
| - name: Upload digest | |||
| uses: actions/upload-artifact@v4 | |||
| uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 | |||
There was a problem hiding this comment.
Suggested change
| uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 | |
| uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 |
.github/workflows/release.yaml
Outdated
| @@ -181,14 +183,16 @@ jobs: | |||
| needs: image | |||
| steps: | |||
| - name: Download digests | |||
| uses: actions/download-artifact@v4 | |||
| uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e | |||
There was a problem hiding this comment.
Suggested change
| uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e | |
| uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7 |
.github/workflows/release.yaml
Outdated
| with: | ||
| path: /tmp/digests | ||
| pattern: digests-* | ||
| merge-multiple: true | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 | ||
| uses: docker/setup-buildx-action@d70bba72b1f3fd22344832f00baa16ece964efeb |
There was a problem hiding this comment.
Suggested change
| uses: docker/setup-buildx-action@d70bba72b1f3fd22344832f00baa16ece964efeb | |
| uses: docker/setup-buildx-action@d70bba72b1f3fd22344832f00baa16ece964efeb # v3.4.0 |
There was a problem hiding this comment.
I changed the comment to use the releases/tag/VERSION form as well. There were a bunch...
And then put the link to the action immediately after the `uses` statement, and prefer tghe `releases/tag/VERSION` form over others.
tomleb
approved these changes
Jul 5, 2024
MbolotSuse
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No related issue