Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing agent-tls-mode Setting value #996

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Handle missing agent-tls-mode Setting value #996

merged 1 commit into from
Jan 13, 2025

Conversation

anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Jan 13, 2025 •
edited
Loading

kind/bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #994

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@anmazzotti anmazzotti requested a review from a team as a code owner January 13, 2025 10:51
@anmazzotti anmazzotti self-assigned this Jan 13, 2025
@anmazzotti anmazzotti added the kind/bug Something isn't working label Jan 13, 2025
@anmazzotti
Handle missing agent-tls-mode Setting value
33612e3 
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti force-pushed the use_default_agent_tls_mode branch from 50c3864 to 33612e3 Compare January 13, 2025 11:01
@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) January 13, 2025 11:14
thehejik
thehejik approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have verified that the change make the import work and the provisioned CAPV/RKE2 cluster is now in Ready state when flag agent-tls-mode flag is enabled.

@Danil-Grigorev Danil-Grigorev merged commit cd5225c into rancher:main Jan 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danil-Grigorev Danil-Grigorev Danil-Grigorev approved these changes

@thehejik thehejik thehejik approved these changes

@salasberryfin salasberryfin salasberryfin approved these changes

Assignees

@anmazzotti anmazzotti

Labels
kind/bug Something isn't working
Projects
CAPI / Turtles
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cluster Pending after Enabling Agent TLS mode
4 participants
@anmazzotti @salasberryfin @thehejik @Danil-Grigorev