feat: opt out of cluster owner rbac #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ccb61a to
7461257
Compare
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
7461257 to
733e176
Compare
furkatgofurov7
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Overall looks good, thanks for taking care of it, LGTM.
@JonCrowther possibly, if you could also take a look that would be great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Preparing for new Rancher release that will include a feature that allows to bypass setting a creator owner on the resource. Import controller now adds the annotation
field.cattle.io/no-creator-rbacon any Rancher clusters it reconciles. This will apply to newly created clusters and to existing ones that are subject to reconciliation.You can take a look at rancher/rancher#47259, where this new option is introduced.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Also updates E2E and import controller tests to check that clusters are properly annotated.
After this is merged, we'll have to wait until next Rancher minor release to consider this as done
Checklist: