-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Perform e2e on CAAPF with hostNetwork: true #654
🌱 Perform e2e on CAAPF with hostNetwork: true #654
Conversation
3dc9162
to
e451747
Compare
In order to use CAAPF for deploying calico CNI as a helm chart we need to replicate the behavior for chart templating: There is an issue for that: rancher-sandbox/cluster-api-addon-provider-fleet#32 which needs to be implemented. |
e451747
to
1195800
Compare
ffceaa5
to
f88de69
Compare
- Install kindnet and calico CNI in the cluster using CAAPF Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
f88de69
to
86589b1
Compare
I don't remember us having discussion on why using CRS should be replaced by CAAPF? |
@furkatgofurov7 This change only adds CSI provisioning tests. CRS are tested upstream, we don’t need to duplicate this if there is an alternative. The CAAPF provides an alternative method, which does not yet have test coverage. This change adds it within turtles. Prior approach to CAAPF is usage of CAAPH, in #448 but since Fleet is installed in every rancher cluster, we can use it to perform same functionality as CAAPH. |
Alright that makes sense, by PR description I had the feeling that CRS are not relevant at all in turtles and we completely drop its usage. Using CAAPF instead of CAAPH is a good improvement towards wider adoption of CAAPF. |
What this PR does / why we need it:
This PR performs CNI installation using CAAPF in the child clusters, which replaces CRS usage in docker clusters in e2e suite.
This change currently requires alpha version of the rancher chart, with version above or equal to
v2.9.1-alpha1
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #651
Special notes for your reviewer:
Checklist: