Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set allow snippet annotation to false #170

Merged
merged 2 commits into from
Oct 8, 2021
+8 −2
Merged

Set allow snippet annotation to false #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04f075b
Set allow snippet annotation to false
galal-hussein Oct 8, 2021
69dd9c3
update package version to 05
galal-hussein Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/rke2-ingress-nginx/generated-changes/patch/values.yaml.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,13 @@

# Process IngressClass per name (additionally as per spec.controller)
ingressClassByName: false
@@ -78,13 +76,13 @@
@@ -73,18 +71,18 @@
# their own *-snippet annotations, otherwise this is forbidden / dropped
# when users add those annotations.
# Global snippets in ConfigMap are still respected
- allowSnippetAnnotations: true
+ allowSnippetAnnotations: false

# Required for use with CNI based kubernetes installations (such as ones set up by kubeadm),
# since CNI and hostport don't mix yet. Can be deprecated once https://github.com/kubernetes/kubernetes/issues/23920
# is merged
Expand Down
2 changes: 1 addition & 1 deletion packages/rke2-ingress-nginx/package.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
url: https://github.com/kubernetes/ingress-nginx/releases/download/helm-chart-4.0.3/ingress-nginx-4.0.3.tgz
packageVersion: 04
packageVersion: 05
# This repository does not use releaseCandidateVersions, so you can leave this as 00.
releaseCandidateVersion: 00