Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tmate step from Fleet-in-Rancher test workflow #2978

Merged
merged 2 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/workflows/e2e-test-fleet-in-rancher.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ on:
fleet_version:
description: Fleet version to install in Rancher
type: string
enable_tmate:
description: Enable debugging via tmate
required: false
default: false
type: boolean
workflow_call:
# Variables to set when calling this reusable workflow
inputs:
Expand Down Expand Up @@ -153,14 +148,6 @@ jobs:
--network "nw01" \
--image docker.io/rancher/k3s:${{ env.SETUP_K3S_VERSION }}

-
name: Set Up Tmate Debug Session
if: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.enable_tmate == 'true' }}
uses: mxschmitt/action-tmate@v3
timeout-minutes: 15
with:
limit-access-to-actor: true

-
name: Set up latest Rancher
run: |
Expand Down
15 changes: 0 additions & 15 deletions dev/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -392,21 +392,6 @@ container image and simply re-used it. You can remove it yourself, either by

This container image will have `act` in his name.

#### Using `act` fails

**Error: The runs.using key in action.yml must be one of: [composite docker node12 node16], got node20**

[action-tmate](https://github.com/mxschmitt/action-tmate) was updated recently
and switched the value of `runs.using` from `node16` in version
[3.16](https://github.com/mxschmitt/action-tmate/blob/v3.16/action.yml) to
`node20` in version
[3.17](https://github.com/mxschmitt/action-tmate/blob/v3.17/action.yml#L7),
which is not yet supported by `act`! But an issue for act with a [corresponding
PR](https://github.com/nektos/act/pull/1988) already exists.

A temporary workaround is to comment the step in the workflow file out which
includes `tmate`.

## Monitoring

This sections describes how to add a monitoring stack to your development
Expand Down
Loading