Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merges gitrepo and gitops controllers #2537

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Merges gitrepo and gitops controllers #2537

merged 3 commits into from
Jun 25, 2024

Conversation

0xavi0
Copy link
Contributor

@0xavi0 0xavi0 commented Jun 19, 2024

Moves all the functionality implemented in the gitrepo controller to the gitopts controller.

Refers to: #2513

@0xavi0 0xavi0 self-assigned this Jun 19, 2024
@0xavi0 0xavi0 force-pushed the 2513-merge-gitrepo-gitopts branch 2 times, most recently from 5061a33 to a9447f0 Compare June 19, 2024 08:54
@p-se p-se mentioned this pull request Jun 19, 2024
Merged
@0xavi0 0xavi0 force-pushed the 2513-merge-gitrepo-gitopts branch 6 times, most recently from 04f8436 to 08ff212 Compare June 20, 2024 10:06
@0xavi0 0xavi0 marked this pull request as ready for review June 20, 2024 12:07
@0xavi0 0xavi0 requested a review from a team as a code owner June 20, 2024 12:07
@manno manno changed the title Merges gitrepo and gitopts controllers Merges gitrepo and gitops controllers Jun 21, 2024
@0xavi0 0xavi0 mentioned this pull request Jun 21, 2024
Merged
@0xavi0 0xavi0 force-pushed the 2513-merge-gitrepo-gitopts branch from ec35369 to 3a1a210 Compare June 25, 2024 07:26
@0xavi0 0xavi0 requested a review from manno June 25, 2024 07:51
weyfonk
weyfonk reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 😎

0xavi0 added 2 commits June 25, 2024 13:02
@0xavi0
Merges gitrepo and gitopts controllers
4d437b1 
Moves all the functionality implemented in the `gitrepo` controller to
the `gitopts` controller.

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0
Remove the disableGitOpts from fleet-controller
264834d 
It also renames the `finalizerutils` to just `finalizer` and documents
its functions

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 force-pushed the 2513-merge-gitrepo-gitopts branch from 3a1a210 to dc4522c Compare June 25, 2024 11:02
@0xavi0
Moves setting UpdateGeneration to the code block where it is checked
a85ccff 
Changes documentatin as suggested in code review.

Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
@0xavi0 0xavi0 force-pushed the 2513-merge-gitrepo-gitopts branch from dc4522c to a85ccff Compare June 25, 2024 12:05
@0xavi0 0xavi0 requested a review from weyfonk June 25, 2024 12:26
weyfonk
weyfonk approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@0xavi0 0xavi0 merged commit f9450f6 into rancher:main Jun 25, 2024
8 checks passed
@0xavi0 0xavi0 mentioned this pull request Jun 25, 2024
Closed
4 tasks
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2024
Merged
@weyfonk weyfonk mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manno manno manno approved these changes

@weyfonk weyfonk weyfonk approved these changes

Assignees

@0xavi0 0xavi0

Labels
kind/refactor
Projects
Fleet
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xavi0 @manno @weyfonk