Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate bundle status from bundleDeployment status resources #2535

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Populate bundle status from bundleDeployment status resources #2535

merged 2 commits into from
Jun 21, 2024

Conversation

rubhanazeem
Copy link
Contributor

@rubhanazeem rubhanazeem commented Jun 18, 2024 •
edited
Loading

Refers to #2115

  • status derived from new bundledeployment.status.resources in bundle reconciler

@rubhanazeem rubhanazeem requested a review from a team as a code owner June 18, 2024 12:22
@rubhanazeem rubhanazeem force-pushed the set-bundle-status-resources-from-bd branch 2 times, most recently from 299e442 to 467f69a Compare June 19, 2024 11:50
@rubhanazeem rubhanazeem mentioned this pull request Jun 19, 2024
Closed
7 tasks
weyfonk
weyfonk reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test case! Leaving a few comments and suggestions.

@rubhanazeem rubhanazeem force-pushed the set-bundle-status-resources-from-bd branch from 467f69a to 7b96567 Compare June 20, 2024 08:44
@rubhanazeem rubhanazeem merged commit 69144fe into rancher:main Jun 21, 2024
8 checks passed
@rubhanazeem rubhanazeem deleted the set-bundle-status-resources-from-bd branch June 21, 2024 08:45
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyfonk weyfonk weyfonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubhanazeem @weyfonk