Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include drift end-to-end tests in CI workflows #2531

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

weyfonk
Copy link
Contributor

@weyfonk weyfonk commented Jun 17, 2024

This includes drift tests, previously omitted, in our CI workflows running single-cluster end-to-end tests.

@weyfonk weyfonk requested a review from a team as a code owner June 17, 2024 14:56
aruiz14
aruiz14 previously approved these changes Jun 17, 2024
Copy link
Contributor

@aruiz14 aruiz14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weyfonk weyfonk force-pushed the e2e-run-drift-tests branch 2 times, most recently from 740e38d to ef04ba8 Compare June 18, 2024 09:25
aruiz14
aruiz14 previously approved these changes Jun 18, 2024
weyfonk added 2 commits June 18, 2024 12:06
This includes drift tests, previously omitted, in our CI workflows
running single-cluster end-to-end tests.
This fixes expectations and makes drift detection tests pass.
@weyfonk weyfonk force-pushed the e2e-run-drift-tests branch from ef04ba8 to 8081fd1 Compare June 18, 2024 10:06
This ensures that a valid patch is applied for drift to happen.
@weyfonk weyfonk merged commit 9f6d9b3 into rancher:main Jun 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants