Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bundleDeployment to store resources in gitRepo status #2523

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

rubhanazeem
Copy link
Contributor

Refers to #2115

Populate gitrepo.status.resources from bundledeployment.status.resources

@rubhanazeem rubhanazeem force-pushed the set-resources-by-bd branch from 66e154f to 40bdb2b Compare June 14, 2024 14:00
@rubhanazeem
Copy link
Contributor Author

There is no new logic involved in this PR. This is mostly refactoring. The existing tests should be enough for this PR

@rubhanazeem rubhanazeem marked this pull request as ready for review June 14, 2024 14:03
@rubhanazeem rubhanazeem requested a review from a team as a code owner June 14, 2024 14:03
@rubhanazeem rubhanazeem force-pushed the set-resources-by-bd branch from 40bdb2b to 8a06b8c Compare June 18, 2024 12:38
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there ;)

@rubhanazeem rubhanazeem force-pushed the set-resources-by-bd branch from 8a06b8c to 1b4f9ea Compare June 18, 2024 14:34
@rubhanazeem rubhanazeem merged commit f825b97 into rancher:main Jun 19, 2024
7 of 8 checks passed
@rubhanazeem rubhanazeem deleted the set-resources-by-bd branch June 19, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants