-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.9] Honor Helm's MaxHistory when using drift correction #2517
Merged
weyfonk
merged 6 commits into
rancher:release/v0.9
from
aruiz14:max-history-rollbacks-0.9
Jun 14, 2024
Merged
[0.9] Honor Helm's MaxHistory when using drift correction #2517
weyfonk
merged 6 commits into
rancher:release/v0.9
from
aruiz14:max-history-rollbacks-0.9
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for troubleshooting and fixing this bug :)
Ideally we'd have tests for this, which in this case most likely mean end-to-end tests.
weyfonk
reviewed
Jun 14, 2024
ec5c832
to
f11e2fc
Compare
Co-authored-by: Corentin Néau <tan.neau@suse.com>
weyfonk
approved these changes
Jun 14, 2024
weyfonk
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2515
MaxHistory
field. This value takes precedence over the config value. Unlike theUpgrade
action, we omitted to set this value, so the releases will only shrink when running an upgrade but not rollbacks`.release
field, referencing the latest release installed. This value is not being updated on rollbacks, hence making the status differ from whathelm history
reflects.