Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout and waiting for testcontainers #2502

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

manno
Copy link
Member

@manno manno commented Jun 10, 2024

No description provided.

@manno manno force-pushed the increase-testcontainers-https-timeout branch from bac40d5 to 51b48ec Compare June 10, 2024 12:01
@manno manno marked this pull request as ready for review June 10, 2024 12:36
@manno manno requested a review from a team as a code owner June 10, 2024 12:36
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; any examples of current failures that this could help fix, eg. CI runs?

@manno
Copy link
Member Author

manno commented Jun 10, 2024

LGTM; any examples of current failures that this could help fix, eg. CI runs?

Yes, this one https://github.com/rancher/fleet/actions/runs/9447074286/job/26018269767#step:5:67
Sorry, we have about four flaky tests over there and I've been copying links into several chats, but not to you :)

@manno manno merged commit 9bdc1e4 into main Jun 10, 2024
8 checks passed
@manno manno deleted the increase-testcontainers-https-timeout branch June 10, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants