Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example values.yaml for enabling OCI storage #2494

Merged

Conversation

bigkevmcd
Copy link
Contributor

Refers to #XXX

Try installing the chart with the example in the values.yaml uncommented, this will not apply cleanly.

This changes the example in the values.yaml for enabling the OCI storage to be valid for insertion into the "env" for a container.

Previously, it was a boolean, which would lead to a failure to unmarshal a bool to a string.

This changes the example in the values.yaml for enabling the OCI storage
to be valid for insertion into the "env" for a container.

Previously, it was a boolean, which would lead to a failure to unmarshal
a bool to a string.
@bigkevmcd bigkevmcd requested a review from a team as a code owner June 7, 2024 09:29
@bigkevmcd bigkevmcd requested a review from 0xavi0 June 7, 2024 09:29
Copy link
Contributor

@0xavi0 0xavi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching.

@bigkevmcd bigkevmcd merged commit 00ce264 into rancher:main Jun 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants