GitRepo Initial Checkout when DisablePolling is True

[Tommy12789]

Refers to #2432

implemented an initial checkout for the gitrepos applied without polling and commit update while force updating

./integrationtests/gitjob/controller/controller_test.go

[0xavi0]

As discussed offline, there is a bug when doing a "Force Update" because the contents are re-deployed but the commit is not updated.

That works because the completed job remains in the cluster and the

	} else if gitRepo.Status.Commit != "" {
		if err = r.deleteJobIfNeeded(ctx, &gitRepo, &job); err != nil {
			return ctrl.Result{}, fmt.Errorf("error deleting git job: %v", err)
		}
	}

code is executed (which recreates the job and fetches the latest from the repository).

But this part:

                        fetcher := git.NewFetcher()
			commit, err := fetcher.LatestCommit(ctx, &gitRepo, r.Client)
			if err != nil {
				return ctrl.Result{}, fmt.Errorf("error fetching commit: %v", err)
			}
			gitRepo.Status.Commit = commit
			logger.V(1).Info("Updating GitRepo status", "commit", gitRepo.Status.Commit)
			if err := r.Status().Update(ctx, &gitRepo); err != nil {
				return ctrl.Result{}, fmt.Errorf("error updating git repo status: %v", err)
			}
			return ctrl.Result{}, nil

is no longer executed and the commit is not updated in the gitrepo.

It is not executed because it deletes the job and then it executes this branch:

     if errors.IsNotFound(err) {
		if gitRepo.Status.Commit != "" {
			if err := r.createJob(ctx, &gitRepo); err != nil {
				return ctrl.Result{}, fmt.Errorf("error creating git job: %v", err)
			}
		}

as gitRepo.Status.Commit is no longer "" like it was for the first time.

[0xavi0]

I guess it would be cool to also test the case that had the bug before, but I guess that requires an e2e test because you need to create a new commit and these tests are relying on the fleet repo in github.
Up to you if you want to experiment and create that.

Aside from the code simplification and the lines that belong to other PRs... LGTM

[0xavi0]

LGTM
Thanks for adding the extra e2e test

[0xavi0]

Nit: This could be flagged as a failure if any previous test failed.