Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing comma from bootstrap template #2452

Merged
merged 1 commit into from
May 27, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

Refers to #XXX

This causes Error("trailing comma", line: 16, column: 13) when using serde_json to deserialize the value and do something with apiServerURL and apiServerCA. Unfortunately this rust framework does not tolerate invalid json content.

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner May 22, 2024 16:18
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution :)

This causes `Error("trailing comma", line: 16, column: 13)` when using serde_json to deserialize the value and do something with apiServerURL and apiServerCA
@weyfonk weyfonk force-pushed the fix-trailing-comma-template branch from de731bb to 3e90afb Compare May 27, 2024 07:47
@weyfonk weyfonk merged commit 2ee1a27 into rancher:main May 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants