Delete namespace when a gitRepo is deleted #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
reviewed
Apr 26, 2024
e2e/assets/single-cluster/delete-namespaces/do-not-delete/gitrepo.yaml
Outdated
Show resolved
Hide resolved
c853a2f to
d1c9796
Compare
weyfonk
reviewed
May 3, 2024
d1c9796 to
bc45622
Compare
Introduce deleteNamespace to cleanup the namespace created to deploy resources
bc45622 to
1ff1997
Compare
weyfonk
reviewed
May 7, 2024
1ff1997 to
1e01aff
Compare
weyfonk
reviewed
May 7, 2024
1e01aff to
3a02999
Compare
weyfonk
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #1564
This PR introduces a new attribute
spec.deleteNamespace: booleanin gitRepo to delete the namespace when gitRepo is deleted. This namespace is created by fleet to deploy the services.Thanks @weyfonk ❤️