Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "fleet test" command, previously used to debug chart #2113

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

manno
Copy link
Member

@manno manno commented Jan 31, 2024

Will be replaced by #2110

The fleet test command, match.Matcher in the code, seems to be mostly useless. See discussion in #1385 (comment)

@manno manno requested a review from a team as a code owner January 31, 2024 11:59
@manno manno merged commit ae86f3f into master Feb 1, 2024
10 checks passed
@manno manno deleted the deprecate-fleet-test-command branch February 1, 2024 11:44
@cornfeedhobo
Copy link

cornfeedhobo commented Mar 17, 2024

This was the most useful command in fleet. I beg you, please revert this.

Edit: fleet test went mostly unused because it was poorly advertise. This can be fixed with better documentation about the proposed development cycles for admins.

@weyfonk
Copy link
Contributor

weyfonk commented Apr 1, 2024

@cornfeedhobo: would the new fleet target be what you are after? See #2110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants