Use private configmap chart for OCI testing #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d13776 to
5d68150
Compare
Those tests requiring external secrets previously relied on a private `guestbook` chart with a front-end server. They now expect a config map, coming from a much more lightweight test chart.
This is a test commit to validate that OCI tests requiring secrets work as expected against a test, configmap-only chart. This must be reverted as soon as the corresponding `fleet-test-data` PR is merged.
This reverts commit 9a9c202.
5d68150 to
4d43f73
Compare
raulcabello
approved these changes
Oct 24, 2023
aruiz14
pushed a commit
that referenced
this pull request
Nov 23, 2023
End-to-end tests requiring external secrets for OCI access previously relied on a private `guestbook` chart with a front-end server. They now expect a config map, coming from a much more lightweight test chart.
aruiz14
pushed a commit
that referenced
this pull request
Nov 23, 2023
End-to-end tests requiring external secrets for OCI access previously relied on a private `guestbook` chart with a front-end server. They now expect a config map, coming from a much more lightweight test chart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes failures in E2E tests requiring secrets, caused by private test chart
guestbook-privatehaving been deleted by mistake.Instead, those tests now use a new, more lightweight configmap-only private test chart.
Refers to #1866.
Depends on fleet-test-data#9.
Test
This relates to E2E tests requiring secrets, hence can only be tested in CI.
See this run against the feature branch from which this PR originates.