Skip to content

Commit

Permalink
add todo
Browse files Browse the repository at this point in the history
  • Loading branch information
p-se committed Apr 4, 2024
1 parent 5af36dd commit 8ec593f
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions e2e/metrics/cluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ var _ = Describe("Cluster Metrics", Label("cluster"), func() {
)
if expectedExist {
Expect(err).ToNot(HaveOccurred())
// TODO What if the cluster has a GitRepo as part of current tests?
// Then the values would not be 0 and they should not be expected to be 0.
// Which means that this test is not independent of other test cases.
// Should we be creating a designated cluster resource instead?
// Or simply do not test the values of the metrics in this test and add another test with a designated cluster to test the values?
Expect(*metric.Gauge.Value).To(Equal(float64(0)), metricName)
} else {
Expect(err).To(HaveOccurred())
Expand Down

0 comments on commit 8ec593f

Please sign in to comment.