Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the need of the builder image, use the OS itself for that #942

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Drop the need of the builder image, use the OS itself for that #942

merged 1 commit into from
Aug 3, 2023

Conversation

davidcassany
Copy link
Contributor

No description provided.

@davidcassany
Drop the need of the builder image, use the OS itself for that
d464a28 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany requested a review from a team as a code owner August 2, 2023 11:06
@davidcassany davidcassany marked this pull request as draft August 2, 2023 11:06
@kkaempf
Copy link
Contributor

kkaempf commented Aug 2, 2023

😮

kkaempf
kkaempf approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This surprises me - a lot 😆

@davidcassany
Copy link
Contributor Author

This surprises me - a lot laughing

Just an idea I had to reduce the images we actually need. I thought that if we include all the packages that are required for building and ISO as part of the SLE Micro for Rancher we can actually use the same image for building. This is a similar trick to what we already do in elemental-toolkit tests. The example OS is already being used to build the ISO of itself. If we do it this way we could drop the builder image, which is a tricky one as it is not based on SLE Micro for Rancher currently.

@davidcassany davidcassany force-pushed the drop_builder_image_need branch from 038d327 to 6d15702 Compare August 2, 2023 12:39
@davidcassany
Copy link
Contributor Author

Goes together with rancher/elemental-toolkit#1812

@davidcassany davidcassany force-pushed the drop_builder_image_need branch from 6d15702 to d464a28 Compare August 2, 2023 14:33
@davidcassany davidcassany added the need/discussion Issues that needs reviewed and are still untriaged by the team label Aug 2, 2023
@davidcassany davidcassany marked this pull request as ready for review August 3, 2023 08:55
@davidcassany davidcassany merged commit b57b3ab into rancher:main Aug 3, 2023
@davidcassany davidcassany deleted the drop_builder_image_need branch August 3, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkaempf kkaempf kkaempf approved these changes

Assignees
No one assigned
Labels
need/discussion Issues that needs reviewed and are still untriaged by the team
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidcassany @kkaempf