Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORCE flag skips all sanity checks on upgrades #905

Merged

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Jul 7, 2023

This commit ensure FORCE flag on upgrades skips all sanity checks. In addition, this commit also relaxes the systemd state check to only abort upgrades on stopping state.

Related to #901

@davidcassany davidcassany requested a review from a team as a code owner July 7, 2023 10:47
@davidcassany davidcassany requested a review from fgiudici July 7, 2023 10:47
This commit ensure FORCE flag on upgrades skips all sanity checks.
In addition, this commit also relaxes the systemd state check to only
abort upgrades on stopping state.

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the force_upgrade_skips_all_checks branch from e8919a4 to 1988ce9 Compare July 7, 2023 10:49
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the force_upgrade_skips_all_checks branch from 64f2bce to 21453da Compare July 7, 2023 11:36
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if isEqualVersion; then
echo "Upgrade already done with release:"
cat ${HOST_DIR}${RELEASE_FILE}
if [ "$FORCE" != "true" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍🏼

@davidcassany davidcassany enabled auto-merge (rebase) July 7, 2023 11:47
@davidcassany davidcassany merged commit 142a695 into rancher:main Jul 7, 2023
@davidcassany davidcassany deleted the force_upgrade_skips_all_checks branch July 7, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants