suc-upgrade: allow OS upgrades on hosts with failed systemd units #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep 4 spaces for tabs Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Fixes rancher#901 Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
|
How can we improve testing here ? /cc @juadk @ldevulder |
|
Just for further background, these sort of checks within script they are all there to prevent concurrent upgrades. IMHO this should be handled at System Upgrade Controller level, there is a stalled issue about it here rancher/system-upgrade-controller#225 . If no concurrent upgrades are prevented at a higher level I'd say we can get rid of some the checks within the upgrade script, like the one causing the issue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before update we check the system status as reported by systemd via the
systemctl is-system-runningcmd, as we want to skip in case the system is shutting down. This would prevent overlapping OS updates.We rely on the command exit code only, which returns error (EXIT_FAILURE) when the state is anything but "running".
The available states are:
This patch enables OS upgrades also when the system is in the "degraded" state.
We have to prevent OS upgrades for the "stopping" state.
For the other states it could be arguable whether it makes sense to hold the OS upgrade or not: this patch maintains the previous behavior.
NOTE: fixed also the tab spacing while there. Anyway, kept in a separate commit, actual patch is pretty small.
Fixes #901