Build ISO using Seedimage in Elemental UI #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6fe9bee to
804bf4e
Compare
af9427f to
1b3db19
Compare
9464872 to
56f4ac5
Compare
juadk
commented
Jun 29, 2023
| .contains('Elemental Teal'); | ||
| .click(); | ||
| if (utils.isOperatorVersion('stable')) { | ||
| cy.contains('Elemental Teal ISO x86_64 v1.1.5') |
There was a problem hiding this comment.
yes, the stable version (1.1.5) is hardcoded, maybe I can delete it and it will choose the first entry but how to be sure it will be always stable. Maybe we can use the OPERATOR_VERSION as a variable. I think I will improve it in a next PR though.
56f4ac5 to
7743c66
Compare
* also include minor fixes and cleanup
7743c66 to
ec63cf9
Compare
d1c1cac to
e7bcf16
Compare
ldevulder
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes many things:
utils.tsISO_TO_TEST: we build from channel onlyOPERATOR_VERSION: replace byOPERATOR_REPOSIde note:
I could use the new command
cy.addOsVersionChannelinUpgrade / Create an OS Version Channelsbut I will do it in a separate PR.Verification runs
UI-K3s-Rancher_Stable ✔️
Channel check: dev
ISO check: no ISO used because we boot PXE for K3s
UI-RKE2-Rancher_Stable ✔️
Channel check: dev
ISO check: latest-dev
UI-K3s-OS-Upgrade-Rancher_Stable ✔️
Channel check: we don't add channel here because we want to start from stable and upgrade to dev
ISO check: no ISO used because we boot PXE for K3s
UI-RKE2-OS-Upgrade-Rancher_Stable ❌ ( not related to this PR )
Channel check: we don't add channel here because we want to start from stable and upgrade to dev
ISO check: we build from stable
Upgrade check: we upgrade to dev
However, we add the dev channel at the beginning of the upgrade test:
And we create an upgrade group with dev version to trigger the upgrade:
UI-RKE2-OBS_Dev ✔️
Channel check: dev
ISO check: latest-dev
UI-RKE2-OBS_Stable ✔️
Channel check: we don't add channel here because we want to test stable ISO
ISO check: we build from stable
UI-RKE2-OBS_Staging ✔️
Channel check: we add the staging channel as we want to test staging ISO
ISO check: we build from staging