Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: install CRDs chart for operator when needed #850

Merged
merged 1 commit into from
May 26, 2023
Merged

ci: install CRDs chart for operator when needed #850

merged 1 commit into from
May 26, 2023

Conversation

ldevulder
Copy link
Contributor

@ldevulder ldevulder commented May 26, 2023 •
edited
Loading

Elemental Operator chart has been split, so newer versions should install all charts.

Verification runs:

@ldevulder ldevulder self-assigned this May 26, 2023
@ldevulder ldevulder requested a review from a team as a code owner May 26, 2023 10:02
davidcassany
davidcassany approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me 👍

fgiudici
fgiudici approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ldevulder ldevulder force-pushed the fix-ci branch 4 times, most recently from d6b9e33 to 7c67d3b Compare May 26, 2023 13:21
davidcassany
davidcassany approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldevulder
ci: install CRDs chart for operator when needed
6210582 
Elemental Operator chart has been split, so newer versions
should install all charts.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
@davidcassany
Copy link
Contributor

@ldevulder I saw verification runs are green, with your permission I am merging this PR. Thanks much for the quick solution 🙏🏽

@davidcassany davidcassany merged commit 6e4e580 into main May 26, 2023
@davidcassany davidcassany deleted the fix-ci branch May 26, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcassany davidcassany davidcassany approved these changes

@fgiudici fgiudici fgiudici approved these changes

Assignees

@ldevulder ldevulder

Labels
area/elemental-operator kind/QA
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldevulder @davidcassany @fgiudici