Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run elemental-register in systemd service #723

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Run elemental-register in systemd service #723

merged 3 commits into from
Mar 10, 2023

Conversation

davidcassany
Copy link
Contributor

Fixes #722

frelon
frelon reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo and should probably update the motd for watching the logs

@davidcassany davidcassany force-pushed the run_elemental-register_in_a_service branch from 16d07d0 to cc0e72d Compare March 10, 2023 09:23
@davidcassany davidcassany requested a review from a team March 10, 2023 09:24
@davidcassany
Copy link
Contributor Author

I still have not test it, as requires a build of many pieces. But I do not expect major surprises, gonna try to test it today.

@davidcassany davidcassany force-pushed the run_elemental-register_in_a_service branch from cc0e72d to 2979f1d Compare March 10, 2023 14:18
@davidcassany
Copy link
Contributor Author

I tested it manually and it worked fine. IMHO this is ready to be reviewed and eventually merged.

@davidcassany
Run elemental-register in systemd service
e14b391 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
quote command to properly include all arguments
5ccdaa5 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany
Update motd to refer the new service
a8c54bd 
Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the run_elemental-register_in_a_service branch from bea7012 to a8c54bd Compare March 10, 2023 16:53
frelon
frelon approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@frelon frelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany merged commit 3998290 into rancher:main Mar 10, 2023
@davidcassany davidcassany deleted the run_elemental-register_in_a_service branch March 10, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frelon frelon frelon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elemental-register is called without inheriting /etc/profile variables and settings
2 participants
@davidcassany @frelon